This repository was archived by the owner on Mar 23, 2023. It is now read-only.
Add unary plus#253
Merged
trotterdylan merged 2 commits intogoogle:masterfrom Feb 17, 2017
Merged
Conversation
S-YOU
force-pushed
the
add_unary_plus
branch
3 times, most recently
from
0a10ba2 to
89ff3d5
Compare
trotterdylan
suggested changes
Feb 16, 2017
Contributor
trotterdylan
left a comment
trotterdylan
left a comment
There was a problem hiding this comment.
Thanks for the PR. This looks great. Just one suggestion for an additional test.
| {args: wrapArgs(42), want: NewInt(42).ToObject()}, | ||
| {args: wrapArgs(1.2), want: NewFloat(1.2).ToObject()}, | ||
| {args: wrapArgs(NewLong(big.NewInt(123))), want: NewLong(big.NewInt(123)).ToObject()}, | ||
| {args: wrapArgs("foo"), wantExc: mustCreateException(TypeErrorType, "bad operand type for unary +: 'str'")}, |
Contributor
There was a problem hiding this comment.
Would you mind adding a test for a type that implements __pos__?
Contributor
Author
There was a problem hiding this comment.
Added one, something like that?
S-YOU
force-pushed
the
add_unary_plus
branch
from
89ff3d5 to
7e69634
Compare
Contributor
trotterdylan
left a comment
trotterdylan
left a comment
There was a problem hiding this comment.
This is great! Thanks for the PR. Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.